Replaced attendance object with transaction #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,11 +77,11 @@ public ResponseEntity<List<Event>> getEventsByBranch(@PathVariable Branch branch | |||
|
|
|||
| @GetMapping("/user/{userId}") | |||
| @PreAuthorize(Constants.HAS_ROLE_MEMBER_AND_ABOVE) | |||
| public ResponseEntity<List<Event>> getUserEventsByRole(@PathVariable Integer userId, @RequestParam("role") @Nullable String role) { | |||
There was a problem hiding this comment.
Wouldnt it be better to get emai from jwt instead of passing user id in url ? @harshjohar 🤔
Rest lgtm
There was a problem hiding this comment.
removed userId from path
ken1000minus7
requested changes
Oct 13, 2023
Comment on lines
81
to
82
| if (eventRole == null){ | ||
| return ResponseEntity.ok(eventService.getUserEventsByRole(userId, EventRole.PARTICIPANT)); |
There was a problem hiding this comment.
According to #51 if event role is not provided all events should be returned
There was a problem hiding this comment.
Now returning all events
…into feat-attend-to-trans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #60